Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value to the isAbsolute function of utils #5652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raksbisht
Copy link
Contributor

Add default value to the isAbsolute function in utils for providing a default behavior when no path is specified, enhancing usability and maintainability.

@joeyguerra
Copy link

Adding this makes sense to me because the way the function is written, it breaks the expectation that it returns a boolean, true or false. Possibly returning undefined breaks my expectation.

@ctcpip
Copy link
Member

ctcpip commented May 9, 2024

consistent-return has entered the chat

it's a good change but arguably a very minor breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants